Server should automatically unadvertise service when advertising client disconnects #684
Comments
jtbandes
added a commit
that referenced
this issue
Nov 29, 2021
**Public API Changes** None **Description** Fixes an issue reported by @Stephenjerry in #650 (comment). When a duplicate service is advertised by the client, the code now correctly shuts down the original service. There is still a `WebSocketClosedError` received with only a single client, when it advertises a service and then disconnects. Filed #684 to track this.
|
This issue has been marked as stale because there has been no activity in the past 6 months. Please add a comment to keep it open. |
|
This issue has been marked as stale because there has been no activity in the past 12 months. Please add a comment to keep it open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a client advertises a service, then disconnects, the server still attempts to forward incoming service requests to that client, and then when the service is called it dumps a WebSocketClosedError to the console.
Expected behavior is: when the client disconnects, the server should automatically unadvertise the service and never make future attempts to send messages to the client.
The text was updated successfully, but these errors were encountered: