-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.8.1 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 3 new parameters to rosapi and rosbridge_server which filter the topics, services, and parameters broadcast by the server to match an array of glob strings.
…ng, and made some style fixes.
Fixed time object field definitions to match documentation.
… rosbridge_udp, and other miscellanous fixes.
Added new parameters for topic and service security. Only topics and services matching the given globs will be available to rosbridge clients.
also accept empty list as the default "do not check globs" value in addition to None. Finally, append rosapi service glob after processing command line input so it's not overwritten
Normal operation (i.e. no globs or successful verification of requests) is now silent, with illegal requests producing a warning.
New rosapi service: get actionlib servers
Without better doc, one does not understand why no topics are published. I thought, something is broken. With this defaults, everything is working out of the box. And for a more secure setup, one can change it.
Fix: Set default to publish all topics
…d crash if nothing was put into the lists as values
…ifications, the rosapi node fails because some rosparams are not defined properly before. Now the launchfiles comply to the websocket version.
Bug fix to rosapi: allow empty lists and set default all for all launch files
Fixed the launch files for the tcp and udp service
…his allows you to switch to a full-duplex transmission of BSON messages and therefore eliminates the need for a base64 encoding of binary data; Use the new mode by starting:'roslaunch rosbridge_server rosbridge_tcp.launch bson_only_mode:=True' or passing '--bson_only_mode' to the rosbridge_tcp.py script
Tests will sleep for 10% extra of the timeout to prevent some situations were the test sleep ended right before the unregister timer fired
Delay unregister to mitigate #138
Implemented a bson_only_mode flag for the TCP version of rosbridge
Prevent a KeyError when bson_only_mode is unset.
Prevent a KeyError when bson_only_mode is unset.
Set default for bson_only_mode in websocket handler and launch file.
Formatting and examples
don't try to set TCP nodelay option for UDP
Document glob
configure travis to use industial ci configuration. Now it uses xenial and kinetic
expose binary_encoder rosparam that was hidden in deep depth
…te debugability; minor linting (#286)
* appease call service using timeout and proper arrival waiting * add queue_size on publisher * test them individually. * add time after wait for service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.