Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212 by blocking
send_message()
while a message is being written.In practice this connects the backpressure to either the
rospy.Subscriber
Thread
(in the case ofMessageHandler
orThrottleMessageHandler
) or theQueueMessageHandler
Thread
in that case.Applications should subscribe with
queue_length
of at least 1 to prevent pushing all the way back to therospy.Subscriber
, which is probably rude to other clients, and/or use the "workersocket" transportLibrary to decouple theWebSocket
from the client main thread.There's still a way to DoS other clients (0 queue_length, never ACK) but this is a net positive for the websocket server:
QueueMessageHandler
actually works instead of dumping messages into Tornado's limitless queue immediately.