Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression to service responses #428

Closed
wants to merge 2 commits into from

Conversation

uahic
Copy link

@uahic uahic commented Aug 14, 2019

TODOS

  • Add tests for service call with compression flags 'png' and 'cbor'
  • The arguments of the service calls are currently (in my understanding) not compressed, I will have a look at this soon

Copy link
Contributor

@mvollrath mvollrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@@ -0,0 +1,3 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be in the repo, it may interfere with other developers. The .vscode path should really be in .gitignore, but you don't have to do that.

@mvollrath
Copy link
Contributor

@uahic still working on this?

@uahic
Copy link
Author

uahic commented Feb 11, 2020

@mvollrath Unfortunately I lack the time right now due to a bunch of new projects :- (

@github-actions
Copy link

This PR has been marked as stale because it has had no activity in the past 90 days. Please remove the stale label or add a comment to keep it open. Thank you for your contribution.

@github-actions github-actions bot added the stale label Nov 12, 2021
@github-actions github-actions bot closed this Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants