Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes: flake8 --select=E402,E731,E741,F821 #621

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 20, 2021

Fix six miscellaneous flake8 issues that formatters like psf/black will not auto-fix.

2     E402 module level import not at top of file
1     E731 do not assign a lambda expression, use a def
1     E741 ambiguous variable name 'l'
2     F821 undefined name 'get_service_uri'

@amacneil
Copy link
Member

Can you add all the fixed checks to setup.cfg in these PRs so we can prevent future regressions?

@cclauss
Copy link
Contributor Author

cclauss commented Aug 20, 2021

Let's just land these PRs and run psf/black and we will pass ALL flake8 tests.

@cclauss
Copy link
Contributor Author

cclauss commented Aug 20, 2021

Adding them is going to mean that each PR has conflicts with all others because they are all modifying the same line.

@amacneil
Copy link
Member

Adding them is going to mean that each PR has conflicts with all others because they are all modifying the same line.

I see, yes makes sense

@jtbandes jtbandes merged commit 0422c97 into RobotWebTools:ros2 Aug 20, 2021
@cclauss cclauss deleted the misc-cleanup branch August 20, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants