-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unused variables: flake8 --select=F841 #623
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ | |
|
||
def calculate_service_response(request): | ||
request_object = json.loads(request) # parse string for service request | ||
args = request_object["args"] # get parameter field (args) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think since this is a test this whole block of commented code (line 38-45) seems to be dead, we can delete it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. actually, maybe leave it there. I'm not sure if the test is being used. someone has been making PRs to fix these tests so maybe it is helpful for now. |
||
# args = request_object["args"] # get parameter field (args) # unused variable | ||
# count = int(args["count"] ) # get parameter(s) as described in corresponding ROS srv-file | ||
# | ||
# message = "" # calculate service response | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
import rospy | ||
from rosbridge_library.rosbridge_protocol import RosbridgeProtocol | ||
from rosbridge_library.util import bson | ||
from twisted.internet.protocol import DatagramProtocol | ||
|
||
|
||
|
@@ -70,7 +69,6 @@ def stopProtocol(self): | |
rospy.loginfo("Client disconnected. %d clients total.", cls.clients_connected) | ||
|
||
def send_message(self, message): | ||
binary = isinstance(message, bson.BSON) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. delete There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
self.write(message) | ||
|
||
def check_origin(self, origin): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest just deleting this line entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.