Example advantage: Use an Object.assign shim

package.json

@@ -19,6 +19,7 @@
     "canvas": "1.1.3",
     "eventemitter2": "~0.4.13",
     "nodejs-websocket": "~0.1.4",
+    "object-assign": "^1.0.0",
     "xmlshim": "~0.0.9"
   },
   "browser": {

src/RosLib.js

@@ -3,7 +3,7 @@
  */
 
 var ROSLIB = this.ROSLIB || {
-  REVISION : '0.10.0-SNAPSHOT',
+  REVISION : '0.10.0-SNAPSHOT'
 };
 
 ROSLIB.Ros = require('./core/Ros');
@@ -35,10 +35,7 @@ ROSLIB.UrdfModel = require('./urdf/UrdfModel');
 ROSLIB.UrdfSphere = require('./urdf/UrdfSphere');
 ROSLIB.UrdfVisual = require('./urdf/UrdfVisual');
 
-//URDF types
-var UrdfTypes = require('./urdf/UrdfTypes');
-Object.keys(UrdfTypes).forEach(function(type) {
-	ROSLIB[type] = UrdfTypes[type];
-});
+// Add URDF types
+require('object-assign')(ROSLIB, require('./urdf/UrdfTypes'));
 
 module.exports = ROSLIB;

src/core/Message.js

@@ -2,19 +2,16 @@
  * @author Brandon Alexander - baalexander@gmail.com
  */
 
+var assign = require('object-assign');
+
 /**
  * Message objects are used for publishing and subscribing to and from topics.
  *
  * @constructor
  * @param values - object matching the fields defined in the .msg definition file
  */
 function Message(values) {
-  var that = this;
-  values = values || {};
-
-  Object.keys(values).forEach(function(name) {
-    that[name] = values[name];
-  });
+  assign(this, values);
 }
 
 module.exports = Message;

src/core/ServiceRequest.js

@@ -2,19 +2,16 @@
  * @author Brandon Alexander - balexander@willowgarage.com
  */
 
+var assign = require('object-assign');
+
 /**
  * A ServiceRequest is passed into the service call.
  *
  * @constructor
  * @param values - object matching the fields defined in the .srv definition file
  */
 function ServiceRequest(values) {
-  var that = this;
-  values = values || {};
-
-  Object.keys(values).forEach(function(name) {
-    that[name] = values[name];
-  });
+  assign(this, values);
 }
 
 module.exports = ServiceRequest;

src/core/ServiceResponse.js

@@ -2,19 +2,16 @@
  * @author Brandon Alexander - balexander@willowgarage.com
  */
 
+var assign = require('object-assign');
+
 /**
  * A ServiceResponse is returned from the service call.
  *
  * @constructor
  * @param values - object matching the fields defined in the .srv definition file
  */
 function ServiceResponse(values) {
-  var that = this;
-  values = values || {};
-
-  Object.keys(values).forEach(function(name) {
-    that[name] = values[name];
-  });
+  assign(this, values);
 }
 
 module.exports = ServiceResponse;