Merge pull request #41 from baalexander/set_max_listener

Sets unlimited number of event listeners.

build/roslib.js

@@ -318,6 +318,9 @@ ROSLIB.Ros = function(options) {
   this.socket = null;
   this.idCounter = 0;
 
+  // Sets unlimited event listeners.
+  this.setMaxListeners(0);
+
   // begin by checking if a URL was given
   if (url) {
     this.connect(url);

src/core/Ros.js

@@ -22,6 +22,9 @@ ROSLIB.Ros = function(options) {
   this.socket = null;
   this.idCounter = 0;
 
+  // Sets unlimited event listeners.
+  this.setMaxListeners(0);
+
   // begin by checking if a URL was given
   if (url) {
     this.connect(url);

test/ros.test.js

@@ -0,0 +1,31 @@
+var expect = chai.expect;
+
+describe('ROS', function() {
+
+  describe('callOnConnection', function() {
+    it('should accept more than EventEmitter2\'s default listeners', function() {
+      // By default, EventEmitter2 only accepts 10 listeners. When more than
+      // the default, a 'warn' property is set on the listener. The firt part
+      // of this test proves the 'warn' property will be set with default
+      // EventEmitter2 settings.
+      var callCount = 50;
+      var eventEmitter = new EventEmitter2();
+      for (var i = 0; i < callCount; i++) {
+        eventEmitter.on('foo', function() { });
+      }
+      expect(eventEmitter._events['foo']).to.have.length(callCount);
+      expect(eventEmitter._events['foo']).to.have.property('warned');
+
+      // The next part of this test shows that the 'warn' property is not set
+      // for Ros, even with the same number of listeners as above.
+      var ros = new ROSLIB.Ros();
+      for (var i = 0; i < callCount; i++) {
+        ros.callOnConnection({});
+      }
+      expect(ros._events['connection']).to.have.length(callCount);
+      expect(ros._events['connection']).to.not.have.property('warned');
+    });
+  });
+
+});
+