Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue_size not passed on topic subscribe #163

Closed
smamessier opened this issue Feb 25, 2015 · 0 comments
Closed

Queue_size not passed on topic subscribe #163

smamessier opened this issue Feb 25, 2015 · 0 comments

Comments

@smamessier
Copy link
Contributor

On topic subscribe, queue_size is simply ignored. On the Websocket server side however, it is read as "msg.queue_length". So adding this line

queue_length: this.queue_size

should fix it.

Around line 1150 in Roslib.js

      if (this.subscribeId) { return; }
      this.ros.on(this.name, this._messageCallback);
      this.subscribeId = 'subscribe:' + this.name + ':' + (++this.ros.idCounter);
      this.ros.callOnConnection({
        op: 'subscribe',
        id: this.subscribeId,
        type: this.messageType,
        topic: this.name,
        compression: this.compression,
        throttle_rate: this.throttle_rate,
        queue_length: this.queue_size /* Added */
      });
    };
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants