Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Possible EventEmitter memory leak detected" by EventEmitter2 #39

Closed
baalexander opened this issue Apr 25, 2013 · 2 comments
Closed

"Possible EventEmitter memory leak detected" by EventEmitter2 #39

baalexander opened this issue Apr 25, 2013 · 2 comments
Assignees

Comments

@baalexander
Copy link
Contributor

I was finally able to reproduce this bug and figure out what was going on.

When a ROS message or service call is supposed to send to the server, it's actually deferred until a WebSocket connection is established. This is by design. However, if you try to send more than 10 messages or service calls to the server before a WebSocket connection has been established with rosbridge, then EventEmitter2 assumes it's a memory leak.

As queueing up via the connection event is by design and allows for easier code, I agree with the original proposal to setMaxListeners(0) so more than 10 requests can be queued up.

I'll fix this when I'm back in town next week unless someone needs it done earlier.

@rctoris
Copy link
Contributor

rctoris commented Apr 26, 2013

👍

@baalexander
Copy link
Contributor Author

Fixed with Pull Request #41.

@ghost ghost assigned baalexander May 7, 2013
k-aguete pushed a commit to k-aguete/roslibjs that referenced this issue Oct 21, 2022
put revision 5 in ros3d.js and ros3d.min.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants