Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ant with Grunt #8

Closed
baalexander opened this issue Mar 18, 2013 · 4 comments
Closed

Replace ant with Grunt #8

baalexander opened this issue Mar 18, 2013 · 4 comments

Comments

@baalexander
Copy link
Contributor

Just because JavaScript has Java in it, doesn't mean we need to use an antiquated build environment. I'll assign this to me unless someone else wants to look at it first.

@ghost ghost assigned baalexander Mar 18, 2013
@rctoris
Copy link
Contributor

rctoris commented Mar 18, 2013

I see no reason to use something fancier for concatenating files together. The (large) advantage of using ant is the fact that it comes ready-to-roll on any Ubuntu system. Grunt, from what I can tell, is early so I went with something more stable for such a simple task.

@baalexander
Copy link
Contributor Author

If it was just concatenating files, maybe. But we can do a lot more, like doc generation, linting, running tests, and minification with grunt.js.

@rctoris
Copy link
Contributor

rctoris commented Mar 18, 2013

It does that too:

minification:

<target name="-minify" depends="-concatenate" description="Minifies JavaScript files"> <exec failonerror="true" executable="${yui}"> <arg value="${build}/${js}" /> <arg value="-o" /> <arg value="${build}/${js.min}" /> </exec> <echo>${js.min}created.</echo> </target>

JS Doc (btw, I added JS doc to everything and it gets generated in the doc folder)
<target name="-doc" depends="-minify" description="Documents JavaScript files"> <exec failonerror="true" executable="${jsdoc}"> <arg value="-d=${doc}" /> <arg value="${src}" /> <arg value="-r" /> </exec> <echo>JSDOC created.</echo> </target>

@rctoris
Copy link
Contributor

rctoris commented Apr 9, 2013

Addressed in #29

@rctoris rctoris closed this as completed Apr 9, 2013
k-aguete referenced this issue in k-aguete/roslibjs Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants