Ports build system to Grunt. Adds linter and fixes found issues. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rctoris
added a commit
that referenced
this pull request
Apr 9, 2013
Ports build system to Grunt. Adds linter and fixes found issues.
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check out the README.md inside the utils directory for instructions on installing an running the new build system. I will be happy to help and clarify any documentation.
In addition to adding Grunt, this pull request also adds a linter using JSHint. It found several issues. Most were minor (trailing spaces, != instead of !==), but some were major (calling non-existant functions).
I also got Grunt to generate documentation, but held off on committing the updated docs as it would ruin this already large diff.
Once again, if any questions on how to use this, or if the documentation needs a better explanation, let me know!