Make tests fail when they log errors #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzraBrooks
force-pushed
the
add-vitest-fail-on-console
branch
from
da99411 to
790e7b2
Compare
EzraBrooks
commented
Nov 9, 2025
| import failOnConsole from "vitest-fail-on-console"; | ||
|
|
||
| failOnConsole({ | ||
| shouldFailOnWarn: false, |
Collaborator
Author
There was a problem hiding this comment.
This is to allow the pre-existing console.warn invocation in the CBOR implementation.
Base automatically changed from
make-all-failurecallbacks-default-to-console.error
to
develop
November 9, 2025 04:11
To ensure that callback failures don't sneak through in testing. Also to ensure we aren't crowding users' consoles during normal operation.
EzraBrooks
force-pushed
the
add-vitest-fail-on-console
branch
from
790e7b2 to
3806fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
To ensure that callback failures don't sneak through in testing.
Also to ensure we aren't crowding users' consoles during normal operation.