Improve test reliability #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the feedback topic
The tests only check a single tf anyway, and the static publisher is more reliable
This provides a cleaner way to start (and kill) all the nodes required for the tests
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
Update OccupancyGridClient.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fibonacci example test should now succeed reliably, and the dependency on
turtle_tf_demois no more.turtle_tf_democrashed sometimes, causing the tf example test to fail. Since the test only checks a single tf's rotation quaternion, a static_transform_publisher can replace it.I also added a launch file that could be used instead of the shell script.
This PR should fix the build errors connected to #115 and #114