Uses prototype for declaring member functions
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think in the future we should at the very least have the commits for the doc and build be separate so we can actually manage pull request reviews. |
|
One issue I noticed when doing the build this time is it uses the person's home directory name in documentation generation, creating a much bigger diff. |
|
Maybe once things are more stable we should just pull request in source changes. |
rctoris
added a commit
that referenced
this pull request
Mar 20, 2013
Uses `prototype` for declaring member functions
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a mixed way of using
ClassName.prototype.functionName = function() {}andthis.functionName = function() {}(from inside the constructor). Using the prototype way allows for browser optimization as it can compile the functions once instead of having to compile each time an object is initialized.