test the visual Urdf elements #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+100 love me some tests |
|
On a related note: I don't see any error handling in the URDF code - should we validate the URDF before (or during) parsing it and at least warn the user something might be off? |
|
We could, but I always saw it as effort into something that will rarely happen. Since we are assuming a ROS connection for the URDF in most cases, ROS won't actually load an invalid URDF. |
jihoonl
pushed a commit
that referenced
this pull request
Jun 29, 2017
…osbridgge_suite for the detail
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
sphere list marker array added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a test to ensure visual URDF elements are parsed correctly. This passed both before and after merging #137
Todo: test some less friendly cases