Indigo devel #167
Merged
Indigo devel #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous patch of using the queue_size was wrong, since the defaults are quite different (100 vs 0). Signed-off-by: Peter Soetens <peter@thesourceworks.com>
|
Is |
|
Thanks for merging ! With the merge, both queue_size and queue_length are used, but the former for re-publishing and queue_size for pushing subscriptions to the web interface. It's part of the ROSBridge protocol, not my own inventions. |
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
remove extra Ds in main file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request adds a Quaternion function and fixes a misconception in a previous patch of Topic.js
According to the roslib websocket protocol queue_size and queue_length are different things and should not come from the same (default) parameter.