remove the (unused) DOMParser shim #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will include the xmlshim in the browser no? |
|
xmlshim provides the The roslibjs build will be almost exactly be the same because this file was already used. The only difference is that it is now more clear. |
|
Cool looks good in that case |
rctoris
added a commit
that referenced
this pull request
Apr 2, 2015
remove the (unused) DOMParser shim
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
Testing in ros3d.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current DOMParser shim is not used, you can verify this by fixing the
package.json:The
xmlshimpackage provides its own shim (which is already used in the roslibjs build). This pull request makes it more clear which shim is used.