Remove canvas dependency #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +41,8 @@ | |||
| "canvas": "./src/util/shim/canvas.js", | |||
| "eventemitter2": "./src/util/shim/EventEmitter2.js", | |||
| "ws": "./src/util/shim/WebSocket.js", | |||
| "xmldom": "./src/util/shim/xmldom.js" | |||
| "xmldom": "./src/util/shim/xmldom.js", | |||
| "../util/decompressPng": "./src/util/shim/decompressPng" | |||
There was a problem hiding this comment.
That's what I also thought but this is the way aliasify works apparently 😞 We could rewrite it using the browser field of the package.json and not use aliasify.
This commit makes sure that - in a browser a canvas element will be used for decoding pngs (no external dependencies needed) - in node it will use the pngparse module which will use the native zlib module to inflate the data
Rayman
force-pushed
the
remove-canvas-dependency
branch
from
a148bb5 to
1cb6e01
Compare
|
Fixed the merge conflict and removed aliasify so that it is more clear how the shims work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canvas dependency makes this library difficult to install on for example travis and windows. This PR removes that dependency such that no native Node.js extensions are needed (no more libcairo2-dev libjpeg8-dev libpango1.0-dev libgif-dev build-essential g++, just JavaScript code).
I modified the logic a bit but I think I tested all the code paths. Maybe we need CI tests to check the library with BSON and/or png compression.
external dependencies needed)
module to inflate the data