Added serverName option to TFClient #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rctoris
added a commit
that referenced
this pull request
Sep 11, 2015
Added serverName option to TFClient
BennyRe
added a commit
to BennyRe/ros3djs
that referenced
this pull request
Sep 14, 2015
With [PR 197 from roslib.js](RobotWebTools/roslibjs#197) the TFClient got the serverName member to allow custom tf2_web_republisher topics or namespaces. This edit adapts the InteractiveMarkerControl to this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tf2_web_republisher was not running in the global namespace or with a different name the TFClient wasn't able to connect to it. With this change you can specify the action server name of the tf2_web_republisher.