Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to EventEmitter 2.2.0 #240

Merged
merged 7 commits into from
Dec 7, 2016
Merged

Upgrade to EventEmitter 2.2.0 #240

merged 7 commits into from
Dec 7, 2016

Conversation

jbcpollak
Copy link
Contributor

@jbcpollak jbcpollak commented Nov 17, 2016 •
edited
Loading

This is an update of #221

  • It builds on @eadlam's changes and upgrades EventEmitter2 to ~2.2.0.
  • In addition, I replaced the deprecated function utils.debug with console.error.

I did the following:

  • updated README.md (EventEmitter isn't the only dependency, so I make the comments generic)
  • Ran tests (they pass)

Note:

  • There are failing test-examples, but the same tests fail on the main develop branch.
  • I cannot update the cdn with the latest version of EventEmitter, I don't know how that works.

I should add this has been experimentally tested with our own code and works fine.

eadlam and others added 7 commits March 26, 2016 18:35
@jihoonl
Copy link
Member

jihoonl commented Dec 7, 2016

Thanks. and sorry for huge delay.

@jihoonl jihoonl merged commit d2ce7d1 into RobotWebTools:develop Dec 7, 2016
k-aguete pushed a commit to k-aguete/roslibjs that referenced this pull request Oct 21, 2022
@KazutoMurase @jihoonl
add lifetime in MarkerClient class (RobotWebTools#240)
d7f88d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbcpollak @jihoonl @eadlam @dantwinkler