add example for advertise_service and fix documentation #281
+29
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
Service.advertise()
was wrong, and there was no example to show users how to advertise a service.As a side note, maybe a
rospy
-style Service handler (return the response object, returnNone
/undefined
to signal a failure) would be more intuitive? If the callback accidentially overwrites the providedresponse
object (see my comment in Service.js:74), that could lead to very unintuitive bugs.