Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for advertise_service and fix documentation #281

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

T045T
Copy link
Contributor

@T045T T045T commented Jan 8, 2018

The documentation for Service.advertise() was wrong, and there was no example to show users how to advertise a service.

As a side note, maybe a rospy-style Service handler (return the response object, return None/undefined to signal a failure) would be more intuitive? If the callback accidentially overwrites the provided response object (see my comment in Service.js:74), that could lead to very unintuitive bugs.

@Behery Behery merged commit 3bc4ec2 into RobotWebTools:develop Jan 11, 2018
k-aguete pushed a commit to k-aguete/roslibjs that referenced this pull request Oct 21, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* update build

* build the latest again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants