-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding some functions to resolve ros message type #49
Conversation
Hi @garaemon -- great start! These are indeed so very useful functions. There a few convention, style, and minor bugs in the file which is also preventing it from properly running through our Grunt build (Travis-CI build output here: https://travis-ci.org/RobotWebTools/roslibjs/builds/12611739). We have listed our guide here as well: http://wiki.ros.org/JavaScriptStyleGuide -- building locally can also be found here: https://github.com/RobotWebTools/roslibjs/tree/devel/utils I'll add some comments where I see some errors in the pull (also note it will be looking for 2-space indentation). |
type: message | ||
}); | ||
messageDetailClient.callService(request, function(result) { | ||
var typedefs = result.typedefs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are never using this local variable.
I've fixed the points you mentioned. |
adding some functions to resolve ros message type
Colored mesh resource markers
Ros.getTopicType
A wrapper of
/rosapi/topic_type
Ros.getMessageDetails
A wrapper of
/rosapi/message_details
Ros.decodeTypeDefs
: adding a utility function to resoluve ros message definitionThe function convert the result of
getMessageDetail
into a dictionary.For example,
sensor_msgs/JointState
will be converted like: