Fix TFClient by removing, rather than adding, a leading '/' character in TFClient.processFeedback() #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in accordance with both the hydro migration guidelines [1] and the implementation of TFClient.subscribe() (TFClient.js:102) [1]: http://wiki.ros.org/hydro/Migration#tf2.2BAC8-Migration.Removal_of_support_for_tf_prefix
|
I will test this out next week on Groovy-Indigo to make sure we have cross-version support. |
|
Actually, it's not only in the hydro guidelines, but the tf2 migration page as well - tf2 removes all leading slashes anyway, and since TfClient connects to tf2_web_republisher, removing any leftover slashes (that may be present in, f.i., the TfClient.fixedFrame parameter) should be fine :) Also, I apologize - the original comment was misleading: It's not all that important whether the slash is added or removed, but it was beind added in one place and removed in another (TfClient.js:102), which left the TfClient unable to find the values in its dict. |
rctoris
added a commit
that referenced
this pull request
May 22, 2014
Fix TFClient by removing, rather than adding, a leading '/' character in TFClient.processFeedback()
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #78
This is in accordance with both the hydro migration guidelines and the implementation of TFClient.subscribe() (TFClient.js:102)