use SteadyTimer for cleaning up inactive streams #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that cleanup works correctly even if system time changes
|
@flixr It is failing to compile. Can you check? https://travis-ci.org/RobotWebTools/web_video_server/jobs/308041688 |
|
It needs the new SteadyTimer, so it will fail in kinetic release until it's available there as well (should happen with next sync). The prerelease already builds fine. |
|
Thanks for the explanation @flixr. I would like to wait for next sync to be safe. Is this ok? |
|
That is fine. |
|
Probably not terribly important, but this change also means that when on slow sim-time (f.i. with a resource-intensive Gazebo simulation), cleanup might happen too soon. Are we okay with that? (I think we are) |
|
This timer is just for a periodic callback to clean up inactive subscribers. I don't see any problem. |
jihoonl
approved these changes
Jan 8, 2018
jihoonl
added a commit
that referenced
this pull request
Jan 8, 2018
jihoonl
pushed a commit
that referenced
this pull request
Jan 8, 2018
so that cleanup works correctly even if system time changes
jihoonl
added a commit
that referenced
this pull request
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that cleanup works correctly even if system time changes