Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "use SteadyTimer for cleaning up inactive streams" #51

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

jihoonl
Copy link
Member

@jihoonl jihoonl commented Jan 8, 2018

Reverts #45 because it fails in indigo. SteadyTimer is only available kinetic+ releases.

Considering that there are active indigo users(#46, #47), it would be better to keep it compatible for both indigo and kinetic.

@jihoonl
Copy link
Member Author

jihoonl commented Jan 8, 2018

@flixr I hope you understand this.

@jihoonl jihoonl merged commit 9a8d433 into develop Jan 8, 2018
@jihoonl jihoonl deleted the revert-45-steady_timer branch January 8, 2018 05:52
jihoonl added a commit that referenced this pull request Jan 8, 2018
@flixr
Copy link
Contributor

flixr commented Jan 8, 2018

Hm... can't we just use master for kinetic+ and make a branch for indigo?
That is how it's done for many other packages...

@jihoonl
Copy link
Member Author

jihoonl commented Jan 11, 2018

We may consider later. But, I would like to minimize maintenance work at the moment unless it is critical... sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants