Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xacro for simulation compatibility #79

Open
wants to merge 3 commits into
base: humble
Choose a base branch
from

Conversation

gabrielcalmon
Copy link

Checklist

  • I have performed a thorough review of my code
  • [N/A] I have sufficiently commented my code
  • [N/A ] The implementation follows the project style conventions
  • [N/A] All project unit tests are passing
  • [N/A] If relevant, documentation has been provided or updated to discuss the changes made
  • [N/A] System integration tests were performed successfully

Changes Made

The alpha_bringup/launch/alpha.launch.py was crashing when using the simulation option.

As it can be found on the forum ROS Answers, the original format <mesh filename="package://alpha_description/meshes/[FILE].stl" /> to call the meshes is not suported by gazebo, just by RVIZ, so the simulation was not working properly. So, it was updated to <mesh filename="file://$(find alpha_description)/meshes/[FILE].stl" />, which support both RVIZ and Gazebo.

The file updeted were alpha_description/urdf/end_effectors/standard_jaws.urdf.xacro
and alpha_description/urdf/alpha.urdf.xacro

Also, it was found that the README.md instructions pointed for the wrong SSH path and owner of the repository.

Associated Issues

No associated Issues.

Testing

The alpha_bringup/launch/alpha.launch.py was tested both with use_sim=true and use_sim=false

Copy link

mergify bot commented May 29, 2024

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants