Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Integrate NVIDIA Docker support #56

Closed
evan-palmer opened this issue Jul 27, 2023 · 1 comment · Fixed by #59
Closed

[FEATURE]: Integrate NVIDIA Docker support #56

evan-palmer opened this issue Jul 27, 2023 · 1 comment · Fixed by #59
Assignees
Labels
enhancement New feature or request mid priority This is a medium priority issue

Comments

@evan-palmer
Copy link
Collaborator

Feature Type

Adding new functionality to the BlueROV2 driver

Problem Description

The current Docker image and devcontainer configuration are defined specifically for folks using the default Ubuntu graphics driver. This decision was made to first provide support for the general population. However, this driver does have it's drawbacks and it can be useful to take advantage of the NVIDIA drivers if those are an option to users (and they work way better).

Feature Description

Integrate the requirements necessary for using the NVIDIA drivers with the Docker image. It will be necessary to determine how to best integrate this in such a way that it can be used when the source implementation is released as an image (re-released). Furthermore, it will be necessary to implement an additional devcontainer.json configuration file to support the NVIDIA driver development environment.

Alternative Solutions

Another idea that I've had is to template the Dockerfiles and to generate these as part of the CI/CD pipeline. This could be templated to integrate the NVIDIA driver packages when a particular flag is set. My last idea would be to create a new Dockerfile altogether and keep them separate; however, I like the stages that already exist and want to continue to take advantage of those.

Additional Context

No response

@evan-palmer evan-palmer added enhancement New feature or request mid priority This is a medium priority issue labels Jul 27, 2023
@evan-palmer
Copy link
Collaborator Author

I've integrated this over in my other (unpublished) project and it works really well. Just need to port it over here

@evan-palmer evan-palmer self-assigned this Jul 27, 2023
@evan-palmer evan-palmer linked a pull request Jul 30, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mid priority This is a medium priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant