Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entrypoints and integrate ros_gz_sim launch file #62

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

evan-palmer
Copy link
Collaborator

Checklist

  • I have performed a thorough review of my code
  • I have sufficiently commented my code
  • The implementation follows the project style conventions
  • All project unit tests are passing
  • If relevant, documentation has been provided or updated to discuss the changes made
  • System integration tests were performed successfully

Changes Made

This PR fixes an issue that I made in my previous commit in which I forgot to update the entrypoints to source the new mesh directory. I also switched out the use of the ExecuteProcess substitution to launch Gazebo with the official ros_gz_sim launch file.

Associated Issues

Testing

Testing was done with the SITL environment

@evan-palmer evan-palmer self-assigned this Jul 31, 2023
@evan-palmer evan-palmer linked an issue Jul 31, 2023 that may be closed by this pull request
@evan-palmer evan-palmer merged commit 0f5792a into main Jul 31, 2023
7 checks passed
@evan-palmer evan-palmer deleted the 61-bug-fix-entrypoints-after-latest-commit branch July 31, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Fix entrypoints after latest commit [FEATURE]: Use ros_gz launch files instead of manual launch
1 participant