Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

apns-push-type header is required on iOS 13 and later #96

Merged
merged 2 commits into from
Oct 11, 2019

Conversation

flexfrank
Copy link
Contributor

Copy link

@whirosan whirosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flexfrank
Copy link
Contributor Author

I added InvalidPushType error.
Thanks.

@cubicdaiya
Copy link

@RobotsAndPencils @nathany If there is no problem, could you approve and merge this?

@junpayment
Copy link

@RobotsAndPencils @nathany
The release of ios13 is approaching 9/19.
I hope you will merge before that.

@nathany
Copy link
Contributor

nathany commented Oct 11, 2019

Thanks. We should probably add something to the README in the headers section.

@nathany nathany merged commit a87bb14 into RobotsAndPencils:master Oct 11, 2019
nathany added a commit that referenced this pull request Oct 11, 2019
nathany added a commit that referenced this pull request Oct 11, 2019
with #96

to remove stutter (push.PushType)
@nathany
Copy link
Contributor

nathany commented Oct 11, 2019

There were a number of lint issues:

push/header.go:32:6: exported type PushType should have comment or be unexported
push/header.go:32:6: type name will be used as push.PushType by other packages, and that stutters; consider calling this Type
push/header.go:35:2: exported const PushTypeAlert should have comment (or a comment on this block) or be unexported

I've changed the API slightly.

@nathany
Copy link
Contributor

nathany commented Oct 11, 2019

release tagged: 0.14.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants