Support providing credentials using AZURE_X environment variables #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbp
pushed a commit
to opstrace/opstrace
that referenced
this pull request
Apr 22, 2021
Adds an `azure-service-principal` credential type and `azure` exporter type. This was tested manually using a freebie Azure account and seems to work fine. Much of the time here was spent just figuring out how to get the credential configured in the Azure Portal UI (hint: Your Application will NOT appear in the Role Assignments dialog until you search for its name in the search bar) For the exporter itself, this is using a patched build that has support for envvar credentials - whereas the stock build requires embedding the credentials in the yaml configuration alongside the list of metrics to fetch. The addition of envvar support is pretty straightforward and allows us to avoid dealing with mangling the yaml configuration file. See also: RobustPerception/azure_metrics_exporter#101 Signed-off-by: Nick Parker <nick@opstrace.com>
4 tasks
nickbp
pushed a commit
to opstrace/opstrace
that referenced
this pull request
Apr 22, 2021
Adds an `azure-service-principal` credential type and `azure` exporter type. This was tested manually using a freebie Azure account and seems to work fine. Much of the time here was spent just figuring out how to get the credential configured in the Azure Portal UI (hint: Your Application will NOT appear in the Role Assignments dialog until you search for its name in the search bar) For the exporter itself, this is using a patched build that has support for envvar credentials - whereas the stock build requires embedding the credentials in the yaml configuration alongside the list of metrics to fetch. The addition of envvar support is pretty straightforward and allows us to avoid dealing with mangling the yaml configuration file. See also: RobustPerception/azure_metrics_exporter#101 Signed-off-by: Nick Parker <nick@opstrace.com>
nickbp
added a commit
to opstrace/opstrace
that referenced
this pull request
Apr 22, 2021
) Adds an `azure-service-principal` credential type and `azure` exporter type. This was tested manually using a freebie Azure account and seems to work fine. Much of the time here was spent just figuring out how to get the credential configured in the Azure Portal UI (hint: Your Application will NOT appear in the Role Assignments dialog until you search for its name in the search bar) For the exporter itself, this is using a patched build that has support for envvar credentials - whereas the stock build requires embedding the credentials in the yaml configuration alongside the list of metrics to fetch. The addition of envvar support is pretty straightforward and allows us to avoid dealing with mangling the yaml configuration file. See also: RobustPerception/azure_metrics_exporter#101 Signed-off-by: Nick Parker <nick@opstrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows optionally defining the account credentials separately from the metrics configuration.