Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove POST service callbacks #131

Closed
helrond opened this issue Feb 9, 2020 · 0 comments · Fixed by #144
Closed

Remove POST service callbacks #131

helrond opened this issue Feb 9, 2020 · 0 comments · Fixed by #144
Labels
verified
Milestone
v1.1

Comments

@helrond
Copy link
Member

helrond commented Feb 9, 2020

Is your feature request related to a problem? Please describe.

As we iterate towards an environment where post_service_callbacks are replaced (see RockefellerArchiveCenter/zodiac#107), we'll need to refactor all services that use these variables.

Describe the solution you'd like

Factor send_post_request() in StoreRoutine out into separate request.
@helrond helrond added this to the v1.1 milestone Feb 15, 2020
helrond added a commit that referenced this issue Feb 20, 2020
@helrond
remove POST service callbacks, fixes #131
b011269
@helrond helrond mentioned this issue Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
verified
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

v1.1 RockefellerArchiveCenter/gemini
1 participant
@helrond