Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All responses should return the identifier(s) of the object(s) that were processed #39

Closed
helrond opened this issue Sep 3, 2019 · 0 comments · Fixed by #40
Closed

Comments

@helrond
Copy link
Member

helrond commented Sep 3, 2019

Is your feature request related to a problem? Please describe.

Users currently have difficulty understanding the location of a particular transfer in the microservice pipeline. In addition, it's often difficult to diagnose errors effectively because it's hard to tell which transfer is throwing an error. Identifiers which are visible and searchable would help remedy both these situations.

Describe the solution you'd like

All services in this application should return the identifier of any object they touch, regardless of whether the service succeeds or fails. Consider breaking this out into a separate JSON key so the response looks like:

{
  "detail": "Yay, it worked!!"
  "objects": ["12345", "35123"]
}

Describe alternatives you've considered

Much of this logging is already happening within applications, but it needs to be visible in the Zodiac UI in order for it to be useful.

helrond added a commit that referenced this issue Sep 12, 2019
@helrond helrond mentioned this issue Sep 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant