Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete slash command and button #27

Closed
CulturalProfessor opened this issue Dec 2, 2023 · 20 comments · Fixed by #54
Closed

Delete slash command and button #27

CulturalProfessor opened this issue Dec 2, 2023 · 20 comments · Fixed by #54
Labels

Comments

@CulturalProfessor
Copy link
Collaborator

Currently we don't have delete feature for whiteboards.

@lelamo2002
Copy link

Hi! I am looking for a project as part of an assignment of my Software Testing classes in university, in which I need to implement/improve an issue by using Test Driven Development. Do you reckon this would be a good issue?

@CulturalProfessor
Copy link
Collaborator Author

If just one issue then it will be a bit of overkill to setup and all,

@lelamo2002
Copy link

while waiting for a reply i ended setting it up already, so that's not a problem for me

@lelamo2002
Copy link

just so i can get it, it should have a delete button right here?

image

and it should be able to be deleted writing something like /whiteboard delete {whiteboardName}?

@CulturalProfessor
Copy link
Collaborator Author

CulturalProfessor commented Dec 2, 2023

just so i can get it, it should have a delete button right here?

image

and it should be able to be deleted writing something like /whiteboard delete {whiteboardName}?

Yeah that's the idea, meanwhile can you also join our channel a contributor was also going to work on this issue, so you guys can collaborate

@lelamo2002
Copy link

how do i join the channel?

@CulturalProfessor
Copy link
Collaborator Author

CulturalProfessor commented Dec 2, 2023

how do i join the channel?

https://open.rocket.chat/channel/white-board-integration-team it's a bit late here let's talk tomorrow

@brf153
Copy link
Contributor

brf153 commented Dec 3, 2023

Hello @CulturalProfessor, I am working on this issue.

@Sumitwarrior7
Copy link
Contributor

Linked the pr for the issue : #35

@brf153
Copy link
Contributor

brf153 commented Dec 15, 2023

/close

@brf153
Copy link
Contributor

brf153 commented Dec 15, 2023

@CulturalProfessor i think it is solved

@CulturalProfessor
Copy link
Collaborator Author

@brf153 delete command is not implemented

@brf153
Copy link
Contributor

brf153 commented Dec 15, 2023

Oh I thought it is same as delete board one..do we need to add a command like /whiteboard delete {boardid} to delete to delete the board? I can work on this issue if you want to

@Sumitwarrior7
Copy link
Contributor

Sumitwarrior7 commented Dec 16, 2023

Delete board button is already implemented, now the issue name should be changed to delete slash command only

@Sumitwarrior7
Copy link
Contributor

please take a look on this pr and tell me for having any changes : #46
As delete slash command will be implemented just after this pr
@CulturalProfessor

@CulturalProfessor
Copy link
Collaborator Author

@Sumitwarrior7 implement the notification suggestion mentioned in channel

@Sumitwarrior7
Copy link
Contributor

i am working on that already, but till now i am not able to crack it
But if i crack it i will update the code for sure

but creating a new message for notifying is also looking good, you can check it #46 and if you still dont fell good for it, i will remove it
@CulturalProfessor

@CulturalProfessor
Copy link
Collaborator Author

No I mean use send notification for sending that "user already exists" message, @brf153 also implemented it recently for list command.

@Sumitwarrior7
Copy link
Contributor

ok implemented notification @CulturalProfessor
please check : #46

@deepsingh245
Copy link

Is this issue resolved i would like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants