Whiteboards with same name #46
Conversation
|
now instead of sending message, notification is getting sent. Video reference: Screencast.from.16-12-23.11.41.51.PM.IST.webm |
|
Here you can see in the video it is written "only you can see this message" in the error message |
whiteboard/enum/uitlityEnum.ts
Outdated
| @@ -39,4 +39,6 @@ export enum UtilityEnum { | |||
| DELETE_MODAL_ID = "delete-modal-id", | |||
| DELETE_ACTION_ID = "delete-action-id", | |||
| DELETE_BLOCK_ID = "delete-block-id", | |||
| NAE_POPUP_MODAL_ID = "nae-popup-modal-id", | |||
There was a problem hiding this comment.
Remove this @Sumitwarrior7 and follow some guidelines
| .setSender(AppSender) | ||
| .setRoom(room) | ||
| .setText( | ||
| `"${newBoardname}" Whiteboard name is already taken. Try different name` |
There was a problem hiding this comment.
check if bold boardname works and change message to ""${newBoardname}" Whiteboard name is already taken. Please try using a different name."
There was a problem hiding this comment.
is this looking good, i have made the boardname bold
|
I have updated the pr for the changes you have discussed above, so please check and tell me if any further changes need to be done @CulturalProfessor |
keep commit messages in a format like |
Creating multiple whiteboards with same name within a room is now restricted.
If a user attempts to change the board's name to one that already exists, an error message will be displayed
Closing Issue : #44
Video Reference:
wb_pr_1.mp4