Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Support for continously updating Preview Block #11

Merged
merged 4 commits into from
Jul 23, 2023
Merged

Conversation

CulturalProfessor
Copy link
Collaborator

@CulturalProfessor CulturalProfessor commented Jul 22, 2023

Closes #5

@CulturalProfessor CulturalProfessor changed the title Preview [Feat]: Support for continously updating Preview Block Jul 22, 2023
method: "GET",
headers: {
"Content-Type": "application/json",
"Content-Security-Policy":
"default-src 'self' http: https: data: blob: 'unsafe-inline' 'unsafe-eval'",
},
}).then((res) => res.json());
});
return await res.json();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid return await

return res.json()

is euqal to return await res.json() here.

whiteboard/helpers/blockBuilder.ts Show resolved Hide resolved
@shiqimei shiqimei merged commit 74bc975 into main Jul 23, 2023
@shiqimei shiqimei deleted the preview branch July 23, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestone 1: Enable creating & editing whiteboard in the Rocket.Chat
2 participants