Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : webpack excalidraw build initialized #4

Merged
merged 2 commits into from
Jul 18, 2023
Merged

feat : webpack excalidraw build initialized #4

merged 2 commits into from
Jul 18, 2023

Conversation

CulturalProfessor
Copy link
Collaborator

Support for excalidraw through webpack bundling in whiteboard App

@shiqimei
Copy link
Collaborator

shiqimei commented Jul 18, 2023 •
edited
Loading

@CulturalProfessor Looks nice overall, can you:

  1. Move build.js scripts into client/scripts folder
  2. Refine package.json script field to add a new build:excalidraw command that executes node scripts/build.js
  3. add notes in README.md to help others use the command npm run build:excalidraw before developing the Rocket.Chat whiteboard app.

@shiqimei
Copy link
Collaborator

LGTM!

@shiqimei shiqimei merged commit 4f405af into main Jul 18, 2023
@shiqimei shiqimei deleted the bitmap branch July 18, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CulturalProfessor @shiqimei