-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Announcement component #114
Open
samad-yar-khan
wants to merge
11
commits into
RocketChat:main
Choose a base branch
from
samad-yar-khan:AnnouncementComponent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[NEW] Announcement component #114
samad-yar-khan
wants to merge
11
commits into
RocketChat:main
from
samad-yar-khan:AnnouncementComponent
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samad-yar-khan
force-pushed
the
AnnouncementComponent
branch
2 times, most recently
from
April 2, 2022 05:14
3ebadf8
to
869f6c8
Compare
debdutdeb
requested changes
Apr 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check why the build is failing.
samad-yar-khan
force-pushed
the
AnnouncementComponent
branch
from
April 3, 2022 10:20
f90f003
to
ad09104
Compare
@debdutdeb I have rebased the branch with the master branch and there are no more build errors. Build is not failing anymore 😅 |
samad-yar-khan
force-pushed
the
AnnouncementComponent
branch
from
April 9, 2022 11:41
ad09104
to
ac4cfaa
Compare
samad-yar-khan
force-pushed
the
AnnouncementComponent
branch
from
April 11, 2022 17:54
ac4cfaa
to
1435a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Mentioned in the issue #113
Proposed changes (including videos or screenshots)
getAnnouncementData('announcement_code')
.announcement
is fetched usinggetAnnouncementData('announcement_code')
code function and passed in the page props.announcement
collection type / schema to store announcements in the database.deleteOldAnnouncemts()
helper function as a cron job which will run once a day and will delete any announcements which are supposed to be unpublished depending on the date. This will ensure that unwanted announcements do not clutter the database.cms/config/initialData/announcemnets.json
will populate the data base.2022-03-30.22-24-46.mp4