This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Add share app #1841
Merged
[NEW] Add share app #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipbrito
suggested changes
Nov 7, 2018
app/src/main/java/chat/rocket/android/settings/ui/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/settings/ui/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
|
@filipedelimabrito pls review |
|
updated |
philipbrito
suggested changes
Nov 8, 2018
|
squashed the irrelevant commit now it is complete from my side. pls review |
philipbrito
reviewed
Nov 8, 2018
app/src/main/java/chat/rocket/android/settings/ui/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
philipbrito
approved these changes
Nov 8, 2018
|
@filipedelimabrito Thanks for guidance, always ready to learn from you😊 |
|
It is always a pleasure @GOVINDDIXIT! Feel free to reach us anytime! All your PRs are welcome! 👊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/android
Closes #1839
##GIF
