This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Video conference #2139
Merged
[NEW] Video conference #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates the chat room and chat details toolbar also.
(check if Jitsi is enabled before showing the respective icons)
|
Exciting 👍 |
philipbrito
commented
Mar 14, 2019
| @@ -33,7 +29,7 @@ class AppLifecycleObserver @Inject constructor( | |||
| } | |||
|
|
|||
| private fun changeTemporaryStatus(userStatus: UserStatus) { | |||
| launch { | |||
| GlobalScope.launch { | |||
There was a problem hiding this comment.
We should use a specific scope here. To be improved in a new PR (see #2140)
…nto new/video-call-support Also enables the video conferencing from the UserDetails fragment.
philipbrito
commented
Mar 16, 2019
| import chat.rocket.android.chatroom.uimodel.MessageUiModel | ||
| import chat.rocket.android.chatroom.uimodel.UrlPreviewUiModel | ||
| import chat.rocket.android.chatroom.uimodel.toViewType | ||
| import chat.rocket.android.chatroom.uimodel.* |
There was a problem hiding this comment.
Dont'use wildcards!
| import android.view.MenuItem | ||
| import android.view.View | ||
| import android.view.ViewGroup | ||
| import android.view.* |
There was a problem hiding this comment.
Don't use wildcards!
| import chat.rocket.android.chatroom.adapter.PEOPLE | ||
| import chat.rocket.android.chatroom.adapter.PeopleSuggestionsAdapter | ||
| import chat.rocket.android.chatroom.adapter.RoomSuggestionsAdapter | ||
| import chat.rocket.android.chatroom.adapter.* |
There was a problem hiding this comment.
Don't use wildcards!
| import chat.rocket.android.emoji.EmojiPickerPopup | ||
| import chat.rocket.android.emoji.EmojiReactionListener | ||
| import chat.rocket.android.emoji.internal.GlideApp | ||
| import chat.rocket.android.emoji.* |
There was a problem hiding this comment.
Don't use wildcards!
| import chat.rocket.android.util.extensions.showToast | ||
| import chat.rocket.android.util.extensions.textContent | ||
| import chat.rocket.android.util.extensions.ui | ||
| import chat.rocket.android.util.extensions.* |
There was a problem hiding this comment.
Don't use wildcards!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings video call support into Rocket.Chat Android app.
This PR also update the Coroutines version to the stable one.
Known issues:
Known improvements to do:
Notes: