-
Notifications
You must be signed in to change notification settings - Fork 553
[IMPROVEMENT] Adds animation when expanding/collapsing the login options #2191
Conversation
|
Looking really nice @HusseinElFeky! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some wrong code formatting here. Please follow our coding style.
@divyanshub024 is the dev who really likes playing with animations here. Feel free to review it too @divyanshub024 . |
Thank you @filipedelimabrito! Ah yes, my mistake regarding code formatting. I just usually use Android Studio Format Code shortcut every while and then, and that must have been the reason. I have just adjusted the continuation indent to be 4 right now through Android Studio's settings. Thanks for the heads up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HusseinElFeky Animations is really looking good, but it is showing wrong (disable) login options for some servers. Could you fix it, please?
@filipedelimabrito I have fixed incorrect login options showing up for some servers. Please let me know if there is any other issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working like a charm now. Thanks @HusseinElFeky!
@RocketChat/android
Changes:
Added animation when expanding/collapsing login options using
ValueAnimator
.Screenshots or GIF for the change: