Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Adds animation when expanding/collapsing the login options #2191

Merged
merged 8 commits into from
Apr 25, 2019
Merged

Conversation

hfeky
Copy link
Contributor

@hfeky hfeky commented Apr 3, 2019

@RocketChat/android

Changes:

Added animation when expanding/collapsing login options using ValueAnimator.

Screenshots or GIF for the change:

Login Animation

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@philipbrito
Copy link
Contributor

Looking really nice @HusseinElFeky! ❤️

Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some wrong code formatting here. Please follow our coding style.

@philipbrito
Copy link
Contributor

@divyanshub024 is the dev who really likes playing with animations here. Feel free to review it too @divyanshub024 .

@hfeky
Copy link
Contributor Author

hfeky commented Apr 4, 2019

Thank you @filipedelimabrito! Ah yes, my mistake regarding code formatting. I just usually use Android Studio Format Code shortcut every while and then, and that must have been the reason. I have just adjusted the continuation indent to be 4 right now through Android Studio's settings. Thanks for the heads up!

@philipbrito philipbrito added this to the 3.4.0 milestone Apr 4, 2019
@philipbrito philipbrito changed the title Added animation when expanding/collapsing login options [IMPROVEMENT] Adds animation when expanding/collapsing the login options Apr 15, 2019
Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HusseinElFeky Animations is really looking good, but it is showing wrong (disable) login options for some servers. Could you fix it, please?

@hfeky
Copy link
Contributor Author

hfeky commented Apr 21, 2019

@filipedelimabrito I have fixed incorrect login options showing up for some servers. Please let me know if there is any other issue.

Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working like a charm now. Thanks @HusseinElFeky!

@philipbrito philipbrito merged commit cc3624f into RocketChat:develop Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants