[CHORE] Update Jitsi library version #2226
Conversation
| logJitsiMeetViewState("Left video conferencing", map) | ||
| finishJitsiVideoConference() | ||
| override fun onConferenceTerminated(map: MutableMap<String, Any>?) { | ||
| if(map!!.containsKey("error")) { |
There was a problem hiding this comment.
okay @filipedelimabrito
| logJitsiMeetViewState("Left video conferencing", map) | ||
| finishJitsiVideoConference() | ||
| override fun onConferenceTerminated(map: MutableMap<String, Any>?) { | ||
| if(map!!.containsKey("error")) { |
There was a problem hiding this comment.
Is there a place where I can find all the keys like the error for the map?
There was a problem hiding this comment.
@filipedelimabrito Actually the Jitsi documentation specified the keys for Map. if the onConferenceTerminated ended successfully no error key will be present else error key will be there. So based on the condition the keys will be present in the map, so here I am just checking for error key.
https://github.com/jitsi/jitsi-meet/tree/master/android#jitsimeetviewlistener
There was a problem hiding this comment.
Thanks for pointing it out @Cool-fire.
| "url" to url | ||
| ) | ||
| ) | ||
| var options = JitsiMeetConferenceOptions.Builder() |
There was a problem hiding this comment.
Should be val not var.
| override fun onConferenceTerminated(map: MutableMap<String, Any>?) { | ||
| if(!map.isNullOrEmpty()){ | ||
| if(map.containsKey("error")) { | ||
| logJitsiMeetViewState("Terminated video conferencing with error", map) |
There was a problem hiding this comment.
This way you'll never finish the video conference if there is an error here.
There was a problem hiding this comment.
I've made the needed changes here.
Thanks for sending this PR @Cool-fire
philipbrito
changed the title
philipbrito
changed the title
@RocketChat/android
Changes:
Implemented the new updated
JitsiMeetViewListenermethods, removed old methods. Implementedview.joininstead of the oldview.LoadURLObject