Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Listen to favorite changes #2236

Merged
merged 5 commits into from
Apr 25, 2019
Merged

Conversation

Adizbek
Copy link
Contributor

@Adizbek Adizbek commented Apr 18, 2019

@RocketChat/android

Closes #2234

@@ -463,6 +464,7 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR
setupToolbar(roomUiModel.name.toString())
setupMessageComposer(roomUiModel)
isBroadcastChannel = roomUiModel.broadcast
isFavorite = roomUiModel.favorite.orFalse()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@philipbrito philipbrito changed the title [FIX] #2234 Handle correctly adding channels to favorites. [FIX] Listen to favorite changes Apr 24, 2019
@philipbrito philipbrito added this to the 3.4.0 milestone Apr 24, 2019
@philipbrito philipbrito merged commit eeca9f1 into RocketChat:develop Apr 25, 2019
@Adizbek Adizbek deleted the bug-fix-2234 branch April 25, 2019 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Channel Details view is not showing that a channel is favorite
2 participants