Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Typing +:emoji_name: reacts to last message #2271

Merged
merged 10 commits into from
May 13, 2019
Merged

[NEW] Typing +:emoji_name: reacts to last message #2271

merged 10 commits into from
May 13, 2019

Conversation

hfeky
Copy link
Contributor

@hfeky hfeky commented Apr 28, 2019 •
edited
Loading

@RocketChat/android

Closes #2190
Closes #2135
Closes #2136

Changes:

  1. When one types +:emoji_name: in the chat, it will automatically react to the last message, just as in the desktop version.
  2. Fixed command text from not being cleared in the composer when entered.
  3. Trimmed command params to fix /me command.

GIF for the change:

Emoji Reaction

@philipbrito philipbrito added this to the 3.4.0 milestone Apr 29, 2019
philipbrito
philipbrito approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@philipbrito philipbrito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for sending this PR @HusseinElFeky!
💯

@philipbrito philipbrito merged commit 1089435 into RocketChat:develop May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@philipbrito philipbrito philipbrito approved these changes

Assignees
No one assigned
Labels
🎉 feature
Projects
None yet
Milestone
3.4.0
2 participants
@hfeky @philipbrito