Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Fixes compound drawables being set to the incorrect direction in RTL languages #2286

Merged
merged 2 commits into from
May 4, 2019

Conversation

hfeky
Copy link
Contributor

@hfeky hfeky commented May 3, 2019

@RocketChat/android

Closes #2285

Changes:

TextView compound drawables are now set to the appropriate direction according to the applied locale direction in the context configuration.

Screenshots or GIF for the change:

Sorting options

@hfeky hfeky changed the title [FIX] Fixes compound drawables being set in the incorrect direction in RTL languages [FIX] Fixes compound drawables being set to the incorrect direction in RTL languages May 3, 2019
Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯 ! Thank you so much for sending this PR @HusseinElFeky

@philipbrito philipbrito added this to the 3.4.0 milestone May 4, 2019
@philipbrito philipbrito merged commit a8d9ec3 into RocketChat:develop May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TextView drawables are incorrectly set in RTL languages
2 participants