Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Sorting on directory is applied immediately when checked. #2293

Merged
merged 3 commits into from
May 6, 2019

Conversation

noor-binte-amir
Copy link
Contributor

@RocketChat/android

Closes #2292

Changes:

Sorting was applied as soon as option is checked.

GIF:

2292-dirsort-solved

@noor-binte-amir noor-binte-amir changed the title [FIX] Sorting on directory is applied right when it is checked. [FIX] Sorting on directory is applied immediately when checked. May 4, 2019
Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nbamir for sending this PR! 💯

@philipbrito philipbrito changed the title [FIX] Sorting on directory is applied immediately when checked. [IMPROVEMENT] Sorting on directory is applied immediately when checked. May 6, 2019
@philipbrito philipbrito added this to the 3.4.0 milestone May 6, 2019
@philipbrito philipbrito merged commit 5769e45 into RocketChat:develop May 6, 2019
@noor-binte-amir noor-binte-amir deleted the 2292-nbamir branch June 19, 2019 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Sorting on directory is not applied until sorting dialogue is cancelled.
2 participants