[NEW] Implemented Webviews for Richmessages #2327
Conversation
|
@filipedelimabrito please review this pr. I have deleted the other pr's and added all into this one |
| } | ||
|
|
||
| }) | ||
| when(heightRatio){ |
There was a problem hiding this comment.
What about the full here? Is it not needed?
There was a problem hiding this comment.
@filipedelimabrito full is not needed here because only tall and compact configurations are using bottomsheet and full configuration requires a new Activity i.e webviewActivity. full doesn't need a bottomsheet.
| //TODO: Open in a configurable sizable webview | ||
| //Open in a configurable sizable webview | ||
| when(temp.webViewHeightRatio){ | ||
| "full" -> openFullWebPage(temp, roomId) |
There was a problem hiding this comment.
What about creating a const with this value and using it in every place on you code?
There was a problem hiding this comment.
@filipedelimabrito I think this property value is not known at compile time to make it const. Correct me If I am wrong.
There was a problem hiding this comment.
@Cool-fire It has nothing about compile time. Make it a const since it is a const.
There was a problem hiding this comment.
@filipedelimabrito I am not getting why to make temp.webViewHeightRatio const. The webviewHeightRatio has values tall, full, compact. How can it be a const?. I think we can't make temp.webViewHeightRatio a const Please correct me if I am wrong @filipedelimabrito
This reverts commit 72e43f5
There was a problem hiding this comment.
@Cool-fire Thanks for sending this PR.
- The missing improvement here was addressed.
@RocketChat/android
Changes:
Implemented Bottomsheet which displays webview for configurable heightRatio.
Screenshots or GIF for the change: