Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic for better inter-instance communication #128

Merged
merged 3 commits into from
Aug 2, 2019

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Jul 31, 2019

This PR improves how the engine triggers inter-instance communication.

Pre-requisite for this Rocket.Chat PR

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #128 into master will decrease coverage by 1.78%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage    59.9%   58.11%   -1.79%     
==========================================
  Files          71       63       -8     
  Lines        2342     2230     -112     
  Branches      344      344              
==========================================
- Hits         1403     1296     -107     
+ Misses        939      934       -5
Impacted Files Coverage Δ
src/server/AppManager.ts 15.06% <0%> (+0.36%) ⬆️
src/server/managers/AppLicenseManager.ts 20.45% <0%> (-2.05%) ⬇️
src/server/errors/index.ts
src/server/managers/index.ts
src/server/accessors/index.ts
src/server/marketplace/license/index.ts
src/server/compiler/index.ts
src/server/storage/index.ts
src/server/logging/index.ts
src/server/bridges/index.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e0f57...00dcd58. Read the comment docs.

@d-gubert d-gubert merged commit e991801 into master Aug 2, 2019
@d-gubert d-gubert deleted the improve-inter-instance-comms branch August 2, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants