Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Star message, report and delete message events #503

Merged
merged 17 commits into from
May 16, 2022
Merged

[NEW] Star message, report and delete message events #503

merged 17 commits into from
May 16, 2022
+203 −11

Conversation

tapiarafael
Copy link

@tapiarafael tapiarafael commented May 3, 2022 •
edited
Loading

What? ⛵

Added definition and listeners for new events IPostMessageStarred, IPostMessageReported.
Added user info in the context of IPostMessageDeleted.

Why? 🤔

Links 🌎

Task
Rocket.chat PR

PS 👀

Rafael Tapia added 10 commits April 27, 2022 15:02
Add new event for message reactions

Verified

This commit was signed with the committer’s verified signature.
mikekasprzak Mike Kasprzak
GPG key ID: 6CD590EF20472354
Verified
Learn about vigilant mode
97d8ad8
Add new event for message follow and unfollow

Verified

This commit was signed with the committer’s verified signature.
mikekasprzak Mike Kasprzak
GPG key ID: 6CD590EF20472354
Verified
Learn about vigilant mode
4a258eb
Add new event for message pin

Verified

This commit was signed with the committer’s verified signature.
mikekasprzak Mike Kasprzak
GPG key ID: 6CD590EF20472354
Verified
Learn about vigilant mode
9d5d872
Add new properties for Message interface

Verified

This commit was signed with the committer’s verified signature.
mikekasprzak Mike Kasprzak
GPG key ID: 6CD590EF20472354
Verified
Learn about vigilant mode
e681d12
Add new event for when a message is starred or unstarred
217705d
Change boolean props to avoid double negative
a0234ad
Add new event for when a message is reported
d05d4f2
Add user in PostMessageDeleted event context
09e7638
Add the reason the message was reported
d177668
Fix to avoid breaking old PostMessageDeleted implementations
f7c41f7
@tapiarafael tapiarafael changed the title [NEW] Star, report and delete message events [NEW] Star message, report and delete message events May 3, 2022
@tapiarafael tapiarafael mentioned this pull request May 3, 2022
Merged
graywolf336
graywolf336 previously requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've identified some major breaking changes that break compatibility with previous versions of the Apps.

@graywolf336 graywolf336 dismissed their stale review May 3, 2022 20:33

Item fixed

@d-gubert d-gubert force-pushed the feat/new-star-report-delete-message-events branch from 0e58b08 to 0f3db85 Compare May 16, 2022 12:15
@d-gubert d-gubert merged commit 8e7c7df into alpha May 16, 2022
@d-gubert d-gubert deleted the feat/new-star-report-delete-message-events branch May 16, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graywolf336 graywolf336

@d-gubert d-gubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tapiarafael @graywolf336 @d-gubert