Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Menus #895

Merged
merged 16 commits into from
Sep 25, 2018
Merged

[FIX] Menus #895

merged 16 commits into from
Sep 25, 2018

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Sep 25, 2018

Before

before

After

after

@tassoevan tassoevan added this to the 2.14.0 milestone Sep 25, 2018
@tassoevan tassoevan changed the title [WIP] [FIX] Menus [FIX] Menus Sep 25, 2018
@tassoevan tassoevan merged commit 670a27d into develop Sep 25, 2018
@tassoevan tassoevan deleted the fix/menubar branch September 27, 2018 21:32
@Anguel
Copy link

Anguel commented Oct 29, 2018

@tassoevan Tasso, thank you so much for this update, it took a while for me to notice the menu option added "Show on unread messages" :-) It actually solves many of the issues reported by users that people overlooked new messages in the past when they were not sitting in front of their computers. I was hoping for this fix for a long time - so from me a big thank you!
Maybe some further improvement suggestions for the case when the user has checked this menu item:
1. It would be nice to make the Rocket Chat client also blink in the task bar when it is started and there are still unread messages pending (e.g. when the user restarts his computer or closes and reopens the RocketChat client).
2. It would be nice to make the client also blink when it is minimized but there are still unread messages pending.
3. Think about making the "Show on unread messages" menu item checked by default, or maybe a silent installer option? Thank you once again!

@tassoevan
Copy link
Collaborator Author

@Anguel There are new features for tray icon/dock/task bar notifications being developed and tested, including the (1) and (2) that you suggested; I just need to test them more in all the platforms. About (3), I'm more into the silent installer option because "Show on unread messages" looks too much intrusive for the most common user.

@Anguel
Copy link

Anguel commented Oct 29, 2018

@tassoevan Thank you for your reply. After some more testing I noticed that on some PCs the new feature did not work at first. But after some playing around or maybe it was the PC restart, it suddenly started working. Very strange, I will observe it...
BTW, it looks like if there is no other app window in focus the RocketChat window opens but when there is another app window in focus it only blinks in the taskbar - that's really nice if you did it on purpose ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants